feat: add correct wrapped subname tags + expiry date #298

TateB · 2023-02-08T01:44:33Z

fixes/features:

support for displaying negative expiry on subname
- negative expiry only applies to subnames with PCC burned
- to test: navigate wrapped-expired-subnames.eth and then click the subnames tab, the "sub" subname should have a negative expiry
show subnames on names page
fix ownership tags always showing as enabled (+ more tests to prevent regression)
show expiry in /my/names list for unwrapped .eth names where user is controller but not registrant
show expiry of PCC subnames
show PCC expired subnames in subnames list
style tweak: make label for names in /my/names black, rest of name grey (previously only tld was grey)
show "not owned" when pcc expired in subnames list
show "not owned" and correct expiry on PCC expired subname pages

cloudflare-workers-and-pages · 2023-02-08T01:49:28Z

Deploying with Cloudflare Pages

Latest commit:	`c006696`
Status:	✅ Deploy successful!
Preview URL:	https://241e8192.ens-app-v3.pages.dev
Branch Preview URL:	https://feat-wrapped-subname-tags.ens-app-v3.pages.dev

View logs

deploysentinel · 2023-02-08T01:55:16Z

Current Cypress Test Results Summary

✅ 79 Passing - ⚠️ 4 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 02/16/2023 03:31:08am UTC)

Run Details

Running Workflow Test on Github Actions

Commit: c006696

Started: 02/16/2023 03:19:42am UTC

⚠️ Flakes

📄 e2e/specs/stateless/05_permissions.spec.js • 3 Flakes

Top 1 Common Error Messages

`null`	3 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Permissions should allow parent owner to burn pcc Retry 1 • Initial Attempt	3.92% (2) 2 / 51 runs failed over last 7 days	96.08% (49) 49 / 51 runs flaked over last 7 days
Permissions should allow name owner to revoke permissions Retry 1 • Initial Attempt	23.91% (11) 11 / 46 runs failed over last 7 days	76.09% (35) 35 / 46 runs flaked over last 7 days
Permissions should allow name owner to revoke change fuses Retry 1 • Initial Attempt	22.86% (8) 8 / 35 runs failed over last 7 days	77.14% (27) 27 / 35 runs flaked over last 7 days

📄 e2e/specs/stateless/04_deleteSubname.spec.js • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Delete subnames wrapped subname with PCC burned should allow name owner to delete Retry 1 • Initial Attempt	36.36% (8) 8 / 22 runs failed over last 7 days	31.82% (7) 7 / 22 runs flaked over last 7 days

View Detailed Build Results

Current Cypress Test Results Summary

✅ 24 Passing - ❌ 1 Failing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 02/16/2023 03:31:08am UTC)

Run Details

Running Workflow Test on Github Actions

Commit: c006696

Started: 02/16/2023 03:19:33am UTC

❌ Failures

📄 e2e/specs/stateful/03_dnsclaim.spec.js • 1 Failure

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes

Import DNSSEC name should not show the success message again once acknowledged
Retry 1 • Initial Attempt

Error: Timed out retrying after 30000ms: Unable to find an element with the text: Manag...

Timed out retrying after 30000ms: Unable to find an element with the text: Manager. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
<html>
  <head>
     
    <meta
      content="width=device-width"
      name="viewport"
    />
    <meta
      charset="utf-8"
    />
    <title>
      leontalbert.com on ENS
    </title>
    <meta
      content="leontalbert.com's profile on the Ethereum Name Service"
      name="description"
    />
    <meta
      content="4"
      name="next-head-count"
    />
    <link
      rel="apple-touch-icon"
      sizes="256x256"
    />
    <link
      rel="icon"
      sizes="32x32"
      type="image/png"
    />
    <link
      rel="icon"
      sizes="16x16"
      type="image/png"
    />
    <link
      rel="manifest"
    />
    <link
      rel="manifest"
    />
    <link
      color="#5bbad5"
      rel="mask-icon"
    />
    <meta
      content="#da532c"
      name="msapplication-TileColor"
    />
    <meta
      content="#F7F7F7"
      name="theme-color"
    />
    <link
      as="style"
      href="/_next/static/css/dda99be3d4397f1f.css"
      rel="preload"
    />
    <link
      data-n-g=""
      href="/_next/static/css/dda99be3d4397f1f.css"
      rel="stylesheet"
    />
    <noscript
      data-n-css=""
    />
    <link
      as="script"
      href="/_next/static/chunks/396703d0-8b57f683ff6de9f4.js"
      rel="prefetch"
    />
    <link
      as="script"
      href="/_next/static/chunks/5668-cf480fac8d823063.js"
      rel="prefetch"
    />
    <link
      as="script"
      href="/_next/static/chunks/5623-16213f3d4eac6835.js"
      rel="prefetch"
    />
    <link
      as="script"
      href="/_next/static/chunks/1100-b5ab7f92a2c3a1f2.js"
      rel="prefetch"
    />
    <link
      as="script"
      href="/_next/static/chunks/321-63f8fb9ec3e8163a.js"
      rel="prefetch"
    />
    <link
      as="script"
      href="/_next/static/chunks/7190-32e93efece71b306.js"
      rel="prefetch"
    />
    <link
      as="script"
      href="/_next/static/chunks/9419-05b0a4f3bdbc6392.js"
      rel="prefetch"
    />
    <link
      as="script"
      href="/_next/static/chunks/7023.8e3b1ea4080f0c71.js"
      rel="prefetch"
    />
    <link
      as="script"
      href="/_next/static/chunks/230.9a40b6f37a04eec5.js"
      rel="prefetch"
    />
    <link
      as="script"
      href="/_next/static/chunks/1933-3b156db35d50e9d6.js"
      rel="prefetch"
    />
    <link
      as="script"
      href="/_next/static/chunks/8238.0e83e10d775c68d7.js"
      rel="prefetch"
    />
    <link
      as="script"
      href="/_next/static/chunks/4267.9474cc7d07737da7.js"
      rel="prefetch"
    />
    <link
      as="script"
      href="/_next/static/chunks/7998.a90ab15454fb8a5d.js"
      rel="prefetch"
    />
    <link
      as="script"
      href="/_next/static/chunks/7209.c74b37f55665fd38.js"
      rel="prefetch"
    />
    <link
      as="script"
      href="/_next/static/chunks/1998-056102ba642e2f07.js"
      rel="prefetch"
    />
    <link
      as="script"
      href="/_next/static/chunks/5424.d82704b706eeb082.js"
      rel="prefetch"
    />
    <link
      as="script"
      href="/_next/static/chunks/9565-842fb9e181415319.js"
      rel="prefetch"
    />
    <link
      as="script"
      href="/_next/static/chunks/945-907eb1a91023fddb.js"
      rel="prefetch"
    />
    <link
      as="script"
      href="/_next/static/chunks/8856.cadd58517f9cd1ad.js"
      rel="prefetch"
    />
    <link
      as="script"
      href="/_next/static/chunks/6099.0b9e11319a0bf006.js"
      rel="prefetch"
    />
    <link
      as="script"
      href="/_next/static/chunks/8263.81275f27bfcfc977.js"
      rel="prefetch"
    />
    <link
      as="script"
      href="/_next/static/chunks/1119.3b4e4d69c936e77e.js"
      rel="prefetch"
    />
    <link
      as="script"
      href="/_next/static/chunks/6051.6b041ee82c68c908.js"
      rel="prefetch"
    />
    <link
      as="script"
      href="/_next/static/chunks/9221.16ab1a951ace38a9.js"
      rel="prefetch"
    />
    <link
      as="script"
      href="/_next/static/chunks/pages/index-cf5fd297ef992c20.js"
      rel="prefetch"
    />
    <link
      as="script"
      href="/_next/static/chunks/pages/faq-4b858c19f4b61bc1.js"
      rel="prefetch"
    />
    <link
      as="script"
      href="/_next/static/chunks/pages/legal/%5Bslug%5D-165558f0bd29f492.js"
      rel="prefetch"
    />
    <link
      as="script"
      href="/_next/static/chunks/pages/my/names-b8972ab68bc117d7.js"
      rel="prefetch"
    />
    <link
      as="script"
      href="/_next/static/chunks/pages/my/settings-70c6ff778686661e.js"
      rel="prefetch"
    />
  </head>
  <body>
    <div
      data-reactroot=""
      id="__next"
    >
      <div
        data-rk=""
      >
        <div
          class="sc-ee88c5e8-0 hiwPRl min-safe"
        >
          <div
            class="sc-ee88c5e8-4 fRdFkx"
          >
            <svg
              class="sc-ee88c5e8-5"
              fill="none"
              height="24"
              role="img"
              viewBox="0 0 24 24"
              width="24"
              xmlns="http://www.w3.org/2000/svg"
            >
              <g
                clip-path="url(#clip0_85_483)"
              >
                <path
                  clip-rule="evenodd"
                  d="M12 19C17.2216 19 21 15.1779 21 11C21 6.8221 17.2216 3 12 3C6.77838 3 3 6.8221 3 11C3 13.1321 3.94218 15.1133 5.56991 16.5923C6.39625 17.3431 6.97858 18.4502 6.99942 19.7199L7.95046 19.2606L9.25513 21.962L5.79361 23.6338C4.9636 24.0346 4 23.4299 4 22.5082V19.7904C4 19.416 3.82952 19.0644 3.55248 18.8126C1.35873 16.8194 0 14.0551 0 11C0 4.92487 5.37258 0 12 0C18.6274 0 24 4.92487 24 11C24 17.0751 18.6274 22 12 22C11.3277 22 10.6684 21.9493 10.0263 21.8519C9.76369 21.8121 9.49428 21.8465 9.25513 21.962L7.95046 19.2606C8.77765 18.8611 9.66476 18.7628 10.4762 18.8859C10.9697 18.9607 11.4786 19 12 19Z"
                  fill="white"
                  fill-rule="evenodd"
                />
              </g>
              <defs>
                <clippath
                  id="clip0_85_483"
                >
                  <rect
                    fill="white"
                    height="24"
                    width="24"
                  />
                </clippath>
              </defs>
            </svg>
            <div
              class="sc-eDvSVe dwZTxx"
              style="color:white"
            >
              Feedback
            </div>
          </div>
          <header
            class="sc-173fb349-0 dbRtfz"
          >
            <div
              class="sc-173fb349-3 dlVJPX"
            >
              <a
                class="sc-173fb349-1 jvOWnQ"
                data-testid="home-button"
                href="/"
              >
                <svg
                  fill="none"
                  height="3rem"
                  role="img"
                  viewBox="0 0 24 24"
                  xmlns="http://www.w3.org/2000/svg"
                >
                  <path
                    d="M4.04902 5.66275C4.27326 5.24475 4.59687 4.88836 4.99133 4.62507L11.6112 0L...

100% (51)

51 / 51 runs
failed over last 7 days

0% (0)

0 / 51 runs
flaked over last 7 days

View Detailed Build Results

LeonmanRolls

Remove yalc

.

add correct wrapped subname tags + expiry date

67a7c7e

github-actions bot temporarily deployed to Preview: (feat/wrapped-subname-tags) February 8, 2023 01:49 Inactive

LeonmanRolls requested changes Feb 8, 2023

View reviewed changes

TateB added 3 commits February 10, 2023 16:39

tags fixes + misc

ecca22b

use remote ensjs

4cd00dc

fix types issues

960b5a3

github-actions bot temporarily deployed to Preview: (feat/wrapped-subname-tags) February 10, 2023 05:55 Inactive

TateB added 2 commits February 10, 2023 17:15

add not owned tag

d0f3897

i think this works?

b7aa2c8

github-actions bot temporarily deployed to Preview: (feat/wrapped-subname-tags) February 10, 2023 07:13 Inactive

fix coverage

389ee40

github-actions bot temporarily deployed to Preview: (feat/wrapped-subname-tags) February 10, 2023 07:18 Inactive

TateB requested a review from LeonmanRolls February 12, 2023 23:40

LeonmanRolls previously approved these changes Feb 13, 2023

View reviewed changes

add hour display for expiry + less than hour

ee24431

github-actions bot temporarily deployed to Preview: (feat/wrapped-subname-tags) February 14, 2023 00:18 Inactive

TateB added 4 commits February 15, 2023 11:00

Merge branch 'dev' into feat/wrapped-subname-tags

bd88d3a

noncemanager fix

afeee47

useBlockTimestamp tweak

902375e

more subnames for testing

66eeacd

github-actions bot temporarily deployed to Preview: (feat/wrapped-subname-tags) February 15, 2023 00:59 Inactive

LeonmanRolls approved these changes Feb 15, 2023

View reviewed changes

update resolver address for 1337

d258412

github-actions bot temporarily deployed to Preview: (feat/wrapped-subname-tags) February 15, 2023 22:09 Inactive

update test

1c73298

github-actions bot temporarily deployed to Preview: (feat/wrapped-subname-tags) February 15, 2023 22:15 Inactive

Merge branch 'dev' into feat/wrapped-subname-tags

e08e23b

github-actions bot temporarily deployed to Preview: (feat/wrapped-subname-tags) February 15, 2023 22:26 Inactive

add date wrap for wrapperData expiryDate

c006696

github-actions bot deployed to Preview: (feat/wrapped-subname-tags) February 16, 2023 00:20 View deployment

LeonmanRolls merged commit 35b3824 into dev Feb 16, 2023

LeonmanRolls deleted the feat/wrapped-subname-tags branch February 1, 2024 01:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add correct wrapped subname tags + expiry date #298

feat: add correct wrapped subname tags + expiry date #298

TateB commented Feb 8, 2023 •

edited

Loading

cloudflare-workers-and-pages bot commented Feb 8, 2023 •

edited

Loading

deploysentinel bot commented Feb 8, 2023 •

edited

Loading

Top 1 Common Error Messages

Test Case Results

Test Case Results

Test Case Results

LeonmanRolls left a comment

feat: add correct wrapped subname tags + expiry date #298

feat: add correct wrapped subname tags + expiry date #298

Conversation

TateB commented Feb 8, 2023 • edited Loading

cloudflare-workers-and-pages bot commented Feb 8, 2023 • edited Loading

Deploying with Cloudflare Pages

deploysentinel bot commented Feb 8, 2023 • edited Loading

Current Cypress Test Results Summary

⚠️ Flakes

Top 1 Common Error Messages

Test Case Results

Test Case Results

Current Cypress Test Results Summary

❌ Failures

Test Case Results

LeonmanRolls left a comment

Choose a reason for hiding this comment

TateB commented Feb 8, 2023 •

edited

Loading

cloudflare-workers-and-pages bot commented Feb 8, 2023 •

edited

Loading

deploysentinel bot commented Feb 8, 2023 •

edited

Loading